Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cc 440 comment login signup errors #683

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

tw2113
Copy link
Member

@tw2113 tw2113 commented Sep 9, 2024

This PR protects against empty results for formatted list arrays.

It also touches up some list management in similar ways we do elsewhere for the plugin, as well as some logic touchups and invalid get_option usage.

@tw2113 tw2113 changed the base branch from main to release270 September 9, 2024 23:49
@tw2113
Copy link
Member Author

tw2113 commented Sep 9, 2024

@guzmandrade-wds Just look at includes/class-settings.php https://github.com/WebDevStudios/constant-contact-forms/pull/683/files#diff-ffe4c5eae4f71cfc06cca2fc4501f5eac2646795e3253f4b5d45c3efe226b592

The PR got mixed up a bit with a merge of main branch into release270 branch.

@tw2113 tw2113 added this to the 2.7.0 milestone Sep 11, 2024
@tw2113 tw2113 requested a review from lindseywb October 8, 2024 18:35
Copy link

@lindseywb lindseywb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tw2113 tw2113 force-pushed the fix/CC-440-comment-login-signup-errors branch from a450621 to 402484b Compare October 8, 2024 22:52
@tw2113 tw2113 merged commit ff30665 into release270 Oct 8, 2024
tw2113 added a commit that referenced this pull request Nov 14, 2024
* Feature/cc 426 new update notification (#674)

* early versions of new notification for urging to update the plugin.

* new notification setup regarding pending updates

* revise notification content to include links to the update page

* fix typo

* early return for non-admins

* remove unneeded comparisons

* early return for non CTCT sections

* Feature/cc 438 failed disconnect submission hardening (#684)

* move our missed api request method to public.

* remove is_connected check and target our list array index more directly

* begin checking if we have a list, but are not connected at the moment, and attempt to save the record

* construct a contact array to match existing code

* new methods to help with email notifications about API issues. Making this more direct and not dependent on logging in to see

* colaborated wordsmithing with Constant Contact

* fill in version number

* Fix/cc 440 comment login signup errors (#683)

* filter out woocommerce specific lists from the forms plugin

* this is not serving any purpose

* return early if we do not have any lists

* while we should have a list item for each, do an empty check before trying to add to array

* wp core get_option only has 2 parameters available to it.

* Fix/cc 444 optin ux updates (#682)

* remove old comments

* build files

* hide optin if we have no lists available but are connected

* build files

* fill in current changelog items, fill in misse CHANGELOG.md items

* plugin version bumps for release branch

* Fix/cc 446 code quality (#687)

* miniscule phpcs

* bump our phpcs minimum php version

* update which standards we use, and exclude a new nested includes folder

* phpcs file cleanup

* strict in array checks, a couple of ignores for miniscule issues

* yoda conditionals and array alignment

* mark output as previously escaped

* fix usage of esc_html__()

* equals alignment

* equals alignment

* split assignment

* phpcs cleanup for our auth link creation

* phpcs cleanup for builder fields file

* strict in array check, code spacing

* remove some commeted out if statement logic

* phpcs cleanup around translated text and array lines

* I am fine with short ternary

* ignore timestamp issue

* various non-breaking phpcs changes

* equal signs alignment and trailing commas

* various phpcs changes for the lists file

* phpcs cleanup for logging class

* equals alignment

* various phpcs touchups

* disregard nonce need due to boolean check only

* phpcs fixes

* misc phpcs but also rename a function to be more specific to our plugin.

* various phpcs touchups

* make use of our textdomain escaping

* make use of our textdomain escaping

* much phpcs, ignoring some for the moment

* we have had this mismatched for what we actually store and pass in for a while

* We should update the option regardless of empty status, so that next disconect/reconnect attempt we make, we do not repeat previous processed entries

* Fix/cc 442 block default selected form (#686)

* attempt to provide a default form if we have at least 1 avaialble, and no pre-existing selected form

* while we are here, touch up our messaging based on available form list. we were showing no dropdown with zero forms

* compiled assets

* handle an npm files version bump in this branch. fix an extra space

* setting a default in this way was not saving attributes and thus not displaying a form. Instead we will provide a "select form" option to force choosing

* build assets

* remove now unused variable

* mark our "Select" item as disabled if it is the only item in the array

* amend our small messaging to reflect creating a form if we have only our blank "Select" item

* build files

* update pot file
@tw2113 tw2113 deleted the fix/CC-440-comment-login-signup-errors branch November 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants